tom-anders / Easy_xkcd

An easy and simple open source xkcd reader
Apache License 2.0
164 stars 41 forks source link

add confirmation to mark all as unread or read #344

Open danjl1100 opened 5 months ago

danjl1100 commented 5 months ago

This is the change we discussed in #342.

For the confirmation dialog, I used the existing action labels for the title, to avoid adding too many new strings (needing translation for i8n).

Let me know what you think of the dialog phrasing, for both the message and positive button label. I put the same text for both "read" and "unread" dialogs, as the end result is similar: the user is clearing their history of read/unread items.

I tested this change on my phone, using the "Earliest unread" action to see the true read/unread state. I wasn't able to see immediate updates in the overview list (compact cards), but I believe that behavior is the same without this update.