search

tom-englert / Wax

An interactive editor for WiX setup projects.
MIT License
220 stars 25 forks source link

feature request: Add a setting to embed .cab file into the .msi file #1

Closed flyingxu closed 7 years ago

flyingxu commented 8 years ago

I would say that should be the default setting and Wax should make it easy.

tom-englert commented 8 years ago

As you may have noticed Wax currently only manages files, not properties.

To have defaults is so easy with WiX - just build a template with your preferences and include it - so I wonder if it's worth building a UI for this, since there are only very few properties for which this would make sense.

Any suggestions how this could be handled?

tom-englert commented 8 years ago

@flyingxu are you sure you need a UI to add a simple EmbedCab="yes" to the MediaTemplate node?

If you think this should be the default setting for WiX, you should post a feature request here: https://github.com/wixtoolset/issues, to change the default template, not give a bad rating for a tool with a totally different scope.

tom-englert commented 7 years ago

This feature is not really in the scope of Wax.