search

tom-englert / Wax

An interactive editor for WiX setup projects.
MIT License
219 stars 25 forks source link

Handling second-tier references #15

Closed Leogiciel closed 7 years ago

Leogiciel commented 7 years ago

I use this nuget package which delivers four dlls but references only the top two of them in the csproj. (see my post on SO explaining this behaviour).

VS and MSbuild both do right at compilation, detecting references from other two libraries and resolving them because they are on the same folder (according to this post ) and the four libraries are in the bin folder.

Wax doesn't detect them, and I understand that's because it's based on csproj file, but if MSBuild can do it maybe we can too ?

Regards

Leogiciel commented 7 years ago

I'm working on it, and I'll send you a pull request.

tom-englert commented 7 years ago

Using Assembly.LoadFile is dangerous, the file will be locked by the VS process forever. I have refactored it using Mono.Cecil (https://github.com/tom-englert/Wax/commit/d36a782b7ffb5d25f897262b4458c14779e02e14)

Leogiciel commented 7 years ago

Nice ! Thank you for the tip, I didn't know about Cecil, it looks amazing !