tom-englert / Wax

An interactive editor for WiX setup projects.
MIT License
219 stars 25 forks source link

ASP.Net non-standard output #21

Closed Leogiciel closed 7 years ago

Leogiciel commented 7 years ago

In ASP.Net applications, MSBUILD generates all dlls and pdbs in TargetDir, but project.FileName is like "{TargetDir}\bin\mainAssembly.dll" for main assembly dll and pdb.

@tom-englert fixed the source file location, removing the hard-coded "bin", but this folder is here to indicate to VS how to deploy the web application : when publishing the web application puts effectively every dll and pdb files into a bin subfolder (eg : {TargetDir}\bin\everydlls.dll).

I'll implement a "non standard output" detection when removing "bin" from the source path, to add it automatically when generating FileComponents in wix file.

tom-englert commented 7 years ago

That is already fixed for #13: https://github.com/tom-englert/Wax/commit/b49c60a4f82aeaaad4ba74393194e709df337b6f - or is there another issue I did not see?

It was not really "non standard output", but wrong interpretation of these file names - it's the target dir, and all references just have to follow this, while the source is just the file name without folder.

Leogiciel commented 7 years ago

I didn't see your last commit b49c60a yesterday, sorry about that.

You understood it right.

Regards Brice Andreota 

Leogiciel commented 7 years ago

I tried your fix, but second-tier references are not going into bin but only in targetdir.

My implementation in my last pull request differs from yours, but is working as expected.

You can choose to implement it the way you want :)

Regards

Leogiciel commented 7 years ago

Fixed with commit 0d1a824