search

tom-englert / Wax

An interactive editor for WiX setup projects.
MIT License
219 stars 25 forks source link

ComponentGroupRef are not inserted in any feature #23

Closed Leogiciel closed 7 years ago

Leogiciel commented 7 years ago

Documentation says : Wax will add a ComponentGroupRef node for all component groups it creates to the first feature it finds in your project. If you have just one feature defined, this will be fine; if you have more than one feature in your setup project, copy or move the entries as desired.

  <Product ...>
    <Feature Id="ProductFeature" Title="ACME.Setup" Level="1">
      <ComponentGroupRef Id="ProductComponents" />
      <ComponentGroupRef Id="de_files" />
      <ComponentGroupRef Id="fr_files" />
    </Feature>
  </Product>

But no componentGroupRef is generated in my Wix project.

tom-englert commented 7 years ago

It works fine for me - can you debug this to see what happens? Add a break point at the method ForceFeatureRef()

Leogiciel commented 7 years ago

The method adds effectively a componentgroupref to first found feature object, but nothing changes in the .wxs file...

Leogiciel commented 7 years ago

I'm trying to understand and fix this...

Leogiciel commented 7 years ago

Freshly created "bin_files" ComponentGroup is not found in my whole project as a ComponentGroupRef :

capture2

My only feature : capture3

tom-englert commented 7 years ago

Maybe just the "Save" was missing? I think you added this in your last PR, right?

Leogiciel commented 7 years ago

Exactly, SourceFile.Save did the trick.

Fixed by commit fe5275b #30