search

tom-englert / Wax

An interactive editor for WiX setup projects.
MIT License
220 stars 25 forks source link

Fix typo and return PropertyNode. Fix #29. #32

Closed Leogiciel closed 7 years ago

tom-englert commented 7 years ago

Please change your settings for the line endings to "checkout as is, commit as is" (core.autocrlf = false), I always get complaints from VS that the line endings are inconsistent.

tom-englert commented 7 years ago

Maybe it would be a good idea to change properties likde public IEnumerable<string> CustomActionRefs in to a method EnumerateCustomActionRefs() to clearly distinguish them from properties that return a collection.

Leogiciel commented 7 years ago

Done. I tried to apply this procedure after having set autocrlf to false, but no changes to commit.

Leogiciel commented 7 years ago

Fix for #29 included