Open tom-hc-park opened 7 years ago
Hi Hyeongcheol ,
Great job on assignment 05.Please find my comments as mentioned below:
Good Luck for STAT 547 :+1:
Thanks, Janani.
Factor management (drop & reorder): Yes File I/O (data): Yes (thorough) Visualization design: Yes File I/O (write figure): Yes (but see comment) Organized GitHub: Partial (see comments) Bonus (more forcats, eg relevel): No Reflection: Yes
Comments:
gap_tsv
variable is a string, so it essentially already has the quotation marks. If you were giving read.tsv a file name instead of a variable containing a string, you would need the quotes.Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.
You did a great job dropping Oceania and manipulating the levels of country by showing the steps and code you used in order to accomplish the task at hand. It would have been nice to see table showing the mean life expectancy values upon which you based the new levels just to show that it did in fact re-order the levels in this manner. You did a good job showing the effects of arrange visually using graphing techniques for the first two plots but I'm not sure why you included the third plot as the colours argument didn't work in your graph. I like that you compared three types of writing and reading files in R and that you described some of the changes that occur with your dataset as it makes the round trip but it would have been nice if you had included that kind of information for future you. You compared two different colour palettes to a previous graph which improved a the interpretation of the graph. It would have been nice to see a graph embedded in your report from ggsave() which you can do with .png files.
Your repo is decently organized but it would have been nice to remove unnecessary folders from the repo and you have easy links to each assignment but it would have been nice to have a description as to what each assignment includes for future reference. Some more descriptions for what you were doing throughout the assignment would have helped the reader follow what you were doing with more ease. Overall, solid effort.