KellyHu
commented
6 years ago Thanks for your feedbacks! I will go through them one by one.
Open xinyaofan opened 6 years ago
KellyHu
commented
6 years ago Thanks for your feedbacks! I will go through them one by one.
@gcohenfr @estellaqi @KellyHu Overall Comments for the code part:
The rmd file cannot knit. Some errors will occur. processing file: 550.Rmd Error in parse_block(g[-1], g[1], params.src) : duplicate label 'anova' Calls: ... process_file -> split_file -> lapply -> FUN -> parse_block
Execution halted.**
It doesn't matter much, since you don't write your report using Rmarkdown.
Good organization and format of the code. Clear headers and useful comments, I can know what's going on in each part easily.
In the "exploratory analysis", you give a really nice plot to show the correlation between continuous variables using ggplot2. That's really great. ggplot can be really powerful to create some interesting and wonderful plots. If you want to learn more about how to use ggplot2, there is a tutorial written by Jenny Bryan which is really useful. And the QQ-plots, box-plots are also good and meaningful to help us understand the data.
Some codes are not efficient and necessary. For more details, you can read the comments for each part.
Overall Comments for the report.
The format and organization of the report is great. The whole report is organized in a logic way and I can navigate to each part easily. One thing need to be noticed is the name for table. Try to give table name instead of making a statement.
The content in each section is great. But for introduction and summary part, it's better to briefly talks about the methodologies and data analysis. For more details, you can read my comments for each section.
Some suggestions for methodologies
For methodologies, I have some doubts on the "Anova" part. You can read about my comments on page6. Try to figure out whether my method to select model makes more sense.
In the end of my comments, I give some suggestions and guidelines for the model diagnostics. I hope it will be helpful for your future work of this project.
Report Review Workers_Jingyi_Huang35.pdf I use Adobe Acrobat to make some comments. So, you need to download and open the pdf file in the Adobe Acrobat in order to read the complete comments.
code review The Link(https://github.com/aiod01/STAT550-450-for-Seniorworkers-from-Korea/blob/master/Code/Workcode_comments_xinyao.Rmd) to download code file added comments.