tom-james-watson / Emote

Emoji Picker for Linux written in GTK3
https://snapcraft.io/emote
GNU General Public License v3.0
658 stars 36 forks source link

Close button in "About" dialog has no effect in some desktop environments #21

Open tomsquest opened 3 years ago

tomsquest commented 3 years ago

Clicking on "close" button of the "About" dialog does not close the aforementioned dialog

image

But, clicking on the close button of the header bar does close the dialog.

tom-james-watson commented 3 years ago

This is a core GTK window, not a custom thing - https://github.com/tom-james-watson/Emote/blob/master/emote/picker.py#L200:L215.

I'll need to check on gnome that it works as expected (not at home) but i think it looks like an upstream bug.

What desktop environment / version is this?

tomsquest commented 3 years ago

Hi,

I am using Kubuntu 20.04. Emote is from Snap, 1.2.0.

rafaelmardojai commented 3 years ago

This happens when the gtk-dialogs-use-header setting is set to False in some environments.

To fix this, you need to destroy the dialog on the response signal.

Something like this should work:

about_dialog.connect('response', lambda dialog, response: about_dialog.destroy())
mdhishamsayed commented 2 years ago

I can reproduce this issue @tom-james-watson

Martina-Neumayer commented 1 year ago

I can confirm this issue also on Mate and Compiz stand-alone mode as well under Arch Linux. Rmb on the about window border and choose "close" works as expected.