search

tom-james-watson / dat-cp

dcp | Dat Copy - remote file copy, powered by the Dat protocol
MIT License
315 stars 21 forks source link

Add confirmation dialog before download #17

Closed martinheidegger closed 5 years ago

martinheidegger commented 5 years ago

Just because its your friend/colleague sending a link, doesn't mean that she won't send you problematic content.

tom-james-watson commented 5 years ago

You can run the program with the dry-run flag (-n), which lets you check what files will be downloaded (or uploaded if creating an archive). Does that not achieve the same thing?

martinheidegger commented 5 years ago

I think that is problematic security-wise: the receipient is usually not as familiar with the app as the sender.

tom-james-watson commented 5 years ago

Decided that you're right! What's your opinion on the new behaviour as detailed in https://github.com/tom-james-watson/dat-cp/pull/18 ?

tom-james-watson commented 5 years ago

If you update dcp you should be able to test out the behaviour. Thanks for your input! Let me know if you have any other feedback.