Feature Request: Easily Enable/Disable Extension

allangarciasilva commented 3 months ago

Description

First, thank you for creating such a useful extension! I have been using Old Reddit Redirect for a while and it works great. However, I've encountered an issue that affects, at least for me, the usability of the extension. Currently, the only way to disable the extension is by turning it off entirely through the Chrome Extensions Manager. This process is somewhat cumbersome, especially for users who might want to frequently switch between the old and new Reddit interfaces.

Proposed Solution

I propose adding a feature that allows users to easily enable or disable the extension directly from the browser toolbar. Users can click on the extension icon to toggle the redirect feature on and off. When the extension is active, the icon could appear in color, and when it's inactive, the icon could change to black and white. This would provide a clear visual indicator of the extension's status.

Availability

I am available and willing to work on this issue. I would appreciate any feedback or suggestions on how best to implement this feature, particularly regarding the desired user experience.

skippybosco commented 3 months ago

Are you suggesting adding a top level menu item to the existing icon (if pinned) like this?

disable-reddit-redirect

I assume if clicked it would refresh the page to the non old version of the page?

tom-james-watson commented 3 months ago

Hey.

I'm not totally against adding something like this these days, honestly. But, to be clear - there have been a couple of previous PRs for this that I ended up rejecting because I didn't want the added complexity in the extension:

https://github.com/tom-james-watson/old-reddit-redirect/pull/14 https://github.com/tom-james-watson/old-reddit-redirect/pull/111

So, yeah, I'm honestly not still convinced that this is something I want to support, so if you go and make a PR, there's a chance it won't be merged. If it's super high quality and works perfectly, then maybe I will consider it.

Things to consider:

This would need to be implemented twice - for manifest v2 and for manifest v3.
I think a context menu entry is probably fine, with something like "Disable Redirect" / "Enable Redirect" as appropriate.
Selection should persist across browser restarts.
Icon should be greyed out when disabled.
Code should be concise, moduralised and not pollute the existing redirect code.

tom-james-watson / old-reddit-redirect