search

tom-james-watson / p2p.chat

p2p video conferencing powered by WebRTC.
MIT License
686 stars 134 forks source link

Delete room #14

Closed pomborenato closed 4 years ago

pomborenato commented 4 years ago

Hi, I managed to run the chat. Now I need to delete the room so that it cannot be more accessible with the link.

tom-james-watson commented 4 years ago

There doesn't exist the concept of room creation or deletion. Room names are globally unique - if you don't pass the link to anybody there is no way for anyone to find it. No history is stored about rooms so if somebody manages to join the same room after you have left, there is no way to tell that there was ever previously somebody in the room.

pomborenato commented 4 years ago

hi, my concern is someone getting to join a room in progress

Em qua., 1 de abr. de 2020 às 06:15, Tom Watson notifications@github.com escreveu:

Closed #14 https://github.com/tom-james-watson/p2p.chat/issues/14.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tom-james-watson/p2p.chat/issues/14#event-3186969193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7JL6BKOQZKGEGVO2UCBIDRKMA2HANCNFSM4LYBNCWA .

-- Renato Romanhol Coelho Setor de Tecnologia da Informação

tom-james-watson commented 4 years ago

Room names are prefixed with a random string, which makes them unguessable. If you go to the homepage and create a room twice with the same name, you'll see that two unique rooms are created.

tom-james-watson commented 4 years ago

The only way for somebody to join a room in progress is if you give them the link to the room.

pomborenato commented 4 years ago

ok, thanks.

Em qua., 1 de abr. de 2020 às 10:59, Tom Watson notifications@github.com escreveu:

The only way for somebody to join a room in progress is if you give them the link to the room.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tom-james-watson/p2p.chat/issues/14#issuecomment-607266512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7JL6ARP6CKG56PZ37U4ODRKNCCVANCNFSM4LYBNCWA .

-- Renato Romanhol Coelho Setor de Tecnologia da Informação

pomborenato commented 4 years ago

Hello, I made an adaptation in the system creating option of login and password for only authorized people to access.

After the user creates the access he has access to the option to create room and share the room link. however, when ending the call the guest who received the link can use the link to communicate with other people, so I wanted an option to invalidate that room after ending the call.

Em quarta-feira, 1 de abril de 2020, Renato Romanhol pomborenato@gmail.com escreveu:

ok, thanks.

Em qua., 1 de abr. de 2020 às 10:59, Tom Watson notifications@github.com escreveu:

The only way for somebody to join a room in progress is if you give them the link to the room.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tom-james-watson/p2p.chat/issues/14#issuecomment-607266512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7JL6ARP6CKG56PZ37U4ODRKNCCVANCNFSM4LYBNCWA .

-- Renato Romanhol Coelho Setor de Tecnologia da Informação

-- Renato Romanhol Coelho Setor de Tecnologia da Informação