tom-james-watson / wikitrivia-generator

MIT License
35 stars 8 forks source link

Filter out cards with dates in the title #7

Open CristianCantoro opened 2 years ago

CristianCantoro commented 2 years ago

Minor bug that allows cheating, items with dates in the description :sweat_smile:

Example: image

This is the corresponding Wikidata item: https://www.wikidata.org/wiki/Q27952702

novalis commented 2 years ago

Another example of this is Raedwald of East Anglia, whose title is "7th-century Anglo-Saxon king" (in case you were thinking \d{4} for your regex).

FlorianCassayre commented 2 years ago

+1 for that!

Here is another edge case example (notice the BCE part):

image

varun-s22 commented 1 year ago

I would be more than happy to fix this stuff out, if this is still not fixed

tom-james-watson commented 1 year ago

A PR would be welcome!