search

tom-james-watson / wikitrivia

Wikidata as a trivia card game.
https://wikitrivia.tomjwatson.com
MIT License
495 stars 86 forks source link

Replace react-beautiful-dnd #115

Open Flaburgan opened 6 months ago

Flaburgan commented 6 months ago

react-beautiful-dnd has been deprecated by Altassian and they now advise using Pragmatic Drag n Drop. They even provide an optional package to automatically migrate from React Beautiful dnd: https://atlassian.design/components/pragmatic-drag-and-drop/optional-packages/react-beautiful-dnd-migration/about

Unfortunately, Sensors are not supported in this migration tool, so we lose the auto moving of cards and probably other features (defined in https://github.com/tom-james-watson/wikitrivia/blob/master/lib/useAutoMoveSensor.ts), so some code has to be rewritten, to be seen what Pragmatic allows to do.

tom-james-watson commented 6 months ago

While it's still supported with security updates, there's not really any point in doing this, as it sounds like there's nothing to gain anyway.

Will leave this open in case somebody wants to have a crack at it.

Flaburgan commented 6 months ago

Personally I have weird behavior with the current lib on https://www.disco2very.org : the cards are moving weirdly when I try to put them on the board. I will investigate and see how hard it is to replace it.