tom-james-watson / wikitrivia

Wikidata as a trivia card game.
https://wikitrivia.tomjwatson.com
MIT License
493 stars 86 forks source link

Issues with date parsing and BC/AD #38

Closed d-sacre closed 2 years ago

d-sacre commented 2 years ago

Unfortunately, I currently do not have any screenshots nor could I click on the Wikipedia link provided (playing on mobile with browser issues). The following bugs occurred within one play-through:

Starting card was "Ancient Egyptian Civilization", which was placed at the year 332. According to a Wikipedia article I used for cross-checking, https://en.wikipedia.org/wiki/Ancient_Egypt the ancient civilization ended 332 BC and not like placed 332 AD.

The error became even more apparent when the next card was "Colt - An American manufacturer". I placed it in the 1800's, but this was deemed incorrect: The extracted founding date was 69 AD, so it was placed before the end of the ancient Egyptian civilization. According to this Wikipedia article https://en.wikipedia.org/wiki/Colt%27s_Manufacturing_Company, the company was founded in 1855.

tom-james-watson commented 2 years ago

https://github.com/tom-james-watson/wikitrivia/issues/12