Increasing difficulty and minimum of 3 years between cards, without changing away from original time periods

tom-james-watson / wikitrivia

Wikidata as a trivia card game.

https://wikitrivia.tomjwatson.com

MIT License

497 stars 87 forks source link

Increasing difficulty and minimum of 3 years between cards, without changing away from original time periods #73

Closed karenerobinson closed 2 years ago

karenerobinson commented 2 years ago

…ds, with a larger min dist for very long-ago events

karenerobinson commented 2 years ago

@benguraldi what do you think of this tweak?

karenerobinson commented 2 years ago

features:

distance between years starts at 10 / 40 / 90 / 160 years, respectively for the 4 time periods
minimum distance between years is 1 / 4 / 9 / 16 years, respectively for the 4 time periods
minimal error catching: if the candidates list is 0 after filtering, filter again without the distance code (instead of throwing an error and stopping)

(edit: replaced these two lines)

distance between years starts at 30 / 60 / 90 / 120 years, respectively for the 4 time periods
minimum distance between years is 3 / 6 / 9 / 12 years, respectively for the 4 time periods

benguaraldi commented 2 years ago

@karenerobinson Sorry, I missed this.

Did you see my most recent revision to #57? I think it handles the selection process more smoothly.

Personally, I like the distance being uniform, but it's up to @tom-james-watson what to do from here.

tom-james-watson commented 2 years ago

Thanks for your PR! I'm going to close this in favour of https://github.com/tom-james-watson/wikitrivia/pull/57, but please do check in on the discussion and get involved. It just doesn't make sense to have PRs implementing what is basically the same thing.