search

tom2tom / emelfm2

paned file manager for gtk2/3
Other
14 stars 7 forks source link

(un-)maximize pane behaves differently between key binding and button #5

Open landroni opened 7 years ago

landroni commented 7 years ago

Have some output in the output pane, say a configure. Then click twice on the maximize / un-maximize button and emelFM2 will resize the pane and keep its contents as expected. Now do the same using the ctrl + w keybinding. Notice how un-maximize will scroll unexpectedly the output. It would be nice if the keybinding behaved similarly to the button action...

tom2tom commented 7 years ago

On Mon, 27 Feb 2017 14:39:08 -0800 landroni notifications@github.com wrote:

Hey, Liviu, long time. We're both still alive !!

Have some output in the output pane, say a configure. Then click twice on the maximize / un-maximize button and emelFM2 will resize the pane and keep its contents as expected. Now do the same using the ctrl + w keybinding. Notice how un-maximize will scroll unexpectedly the output. It would be nice if the keybinding behaved similarly to the button action...

When the output pane height changes, it attempts to keep the top of the displayed text at the top of the pane, both before and after the size-change. That normally causes the scroll-position to change. IMHO better to do that, than lose sight of your focus-point.

Regards Tom

landroni commented 7 years ago

Hey Tom, great to hear from you!

When the output pane height changes, it attempts to keep the top of the displayed text at the top of the pane, both before and after the size-change.

I agree that this is what should happen when the output isn't scrolled all the way down -- but the latter is a corner case instance that emelFM2 should probably recognize and ensure that the output is scrolled all the way to the bottom when (1) pane is currently scrolled to the bottom and (2) pane was previously scrolled to the bottom.

This is what output.expand does currently, and I think it's the right way to handle this particular instance.