search

tom472 / mediabox

Container based media tools configuration
MIT License
428 stars 83 forks source link

Tool for .sh scripting #38

Closed jthegedus closed 6 years ago

jthegedus commented 6 years ago

@tom472 Just a suggestion, but I've found https://github.com/koalaman/shellcheck extremely helpful for doing any .sh work. Highly recommend :+1:

just thought I would share this if you didn't know about it.

tom472 commented 6 years ago

Thanks - Yes - I've seen that and used it from time to time.

I am thinking of starting to add version numbers to Mediabox. If I start to do that I am also going to start running the code through code checkers/cleaners.

The first goal was to get something that works - now that I have pretty much made it to that point, it's time to make it better.

Thanks again for the suggestion.

jthegedus commented 6 years ago

This sounds great, thanks for your work! :slightly_smiling_face:

CircleCI recently added an OSS guide should you want to use it - https://circleci.com/docs/2.0/oss/