search

tom472 / mediabox

Container based media tools configuration
MIT License
428 stars 83 forks source link

Update docker-compose version #46

Closed trevor-e closed 6 years ago

trevor-e commented 6 years ago

Currently docker-compose.yml is set to version: '2' which I believe is fairly out of date. On my local setup I'm using an NFS volume for some images which requires features available in version 3.x+. Eg:

volumes:
    nfsMount:
        driver: local
        driver_opts:
            type: nfs
            o: addr=192.168.1.23
            device: ":/nfs/Public"

Everything appears to work fine after setting version: 3.5 and would be nice to have upstream too. Thanks for the great project!

tom472 commented 6 years ago

I'll try and get this done quickly.

Thanks for using Mediabox and stopping by to let me know about issues.

tom472 commented 6 years ago

Compose version changed in the docker-compose.yml file has been changed to 3.5. Via: https://github.com/tom472/mediabox/commit/98a367ac01129e56c88ebba6f7e38ccd43d0fa3b While the structure of the file has not been re-configured yet - all seems to works as expected.

Thanks @trevor-e for mentioning it and for the suggestion. Hope this makes you NFS mount usage easier to use.

trevor-e commented 6 years ago

Awesome, thanks. 👍