tom5079 / Pupil

Hitomi.la viewer for Android
Other
414 stars 17 forks source link

[Feature Request] Hitomi.la DL enhancement #150

Closed Ero-gamer closed 6 months ago

Ero-gamer commented 6 months ago

Feature request to add option to choose between native encoded image format: avif and jxl over webp, jpeg and png for downloads.

When I save images from hitomi.la directly while on browser, I get them as .avif image format which is better compressed compared to .webp. But when I download archive or images from Pupil app, I always get .webp images, and there is no way to download .avif or .jxl image formats.

Possible solution: make saving individual images from Hitomi.la automated.

tom5079 commented 6 months ago

Android BitmapRegionDecoder used to decode images in this app only supports JPEG, PNG, WebP and HEIF, so we cannot use .avif or .jxl image formats.

tom5079 commented 6 months ago

For jpeg and png, hitomi got rid of those formats in favor of avif and webp so it does not exist on the hitomi server.

Ero-gamer commented 6 months ago

I know that, what I want is avif format. When I save image file on Hitomi website using Brave browser, I get .avif image format. But when I download images from Pupil app, I get images on .webp format only, no option to choose .avif format. Why not add option to download .avif/.jxl format as archive only? So users can choose to download between webp and avif format then view it on device using external app.

tom5079 commented 6 months ago

I don't know if it is a good choice to let users download the image and not being able to display in app. If I had to add the option to download avif/jxl I think I also have to add support for displaying avif/jxl which is planned for now but not actively in development at this point.

Ero-gamer commented 6 months ago

I don't know if it is a good choice to let users download the image and not being able to display in app. If I had to add the option to download avif/jxl I think I also have to add support for displaying avif/jxl which is planned for now but not actively in development at this point.

I see, thank you for your fast reply and looking forward to future update when avif/jxl format is added for download/view.

PS: consider Coil as in-app image decoder because it is fast, lightweight, regulary updated, support avif and many other format, has the best image resampling/subsampling quality filter and it is already used by many apps including EhViewer.