search

tom5454 / CustomPlayerModels

Customize your minecraft avatar!
https://www.curseforge.com/minecraft/mc-mods/custom-player-models
MIT License
144 stars 47 forks source link

Skin Model does not update when updated through Skin Swapper unless you restart game #23

Closed Lucipo closed 3 years ago

Lucipo commented 3 years ago

latest version as of Feb 25th, 2021, fabric

Pretty much the title, you can upload and everything works but you have to restart game for it to change client-side, when it was instant without this mod.

tom5454 commented 3 years ago

For the skin change to take effect you have to exit to the title screen and wait 15 seconds for the cache to clear. You can't change skins while in the world.

Lucipo commented 3 years ago

Nah I mean with this mod: https://www.curseforge.com/minecraft/mc-mods/skin-swapper

The changes apply to the MC account, namemc, and vanilla, but the skin you launch the client with still persists with the attached model. Without custom player models installed, it is instant for the client and all other players on all platforms.

tom5454 commented 3 years ago

Custom Player Models has a cache that clears after 15 seconds of the model not showing, then it should re-download everything.

Lucipo commented 3 years ago

Custom Player Models has a cache that clears after 15 seconds of the model not showing, then it should re-download everything.

Can you try to reproduce it and use the mod in fabric and change skin with skin swapper from a vanilla skin to model skin and visa versa? Because it isnt working at all

Modpack incase you want a mod list: https://www.curseforge.com/minecraft/modpacks/neoteric-vanilla

Your mod isnt in there yet, if you are to test it then drag it in after installation

tom5454 commented 3 years ago

I loaded up your modpack with a debugger, and when I join the world it downloads the skin, and loads the model. Minecraft is storing the skin url and doesn't refresh it after the skin change.

Lucipo commented 3 years ago

So is the compatibility issue fixable? The people on our server kind of cant restart all of our games everytime we want to show off a model or different skin

tom5454 commented 3 years ago

I tested your modpack without custom player models installed and the skin-swapper mod doesn't work at all. Minecraft stores the skin url. The skin change will show up for other players on a server if you relog, but your own skin is handled differenty. It is loaded the first time you join a world, and there is no way to unload it in vanilla. (cobrasrock/Skin-Swapper#8) Skin swapper has to clear this cache when swapping the skin.

Lucipo commented 3 years ago

Ok thanks a lot for looking into it for me and sorry for the troubles