search

tom5454 / CustomPlayerModels

Customize your minecraft avatar!
https://www.curseforge.com/minecraft/mc-mods/custom-player-models
MIT License
149 stars 49 forks source link

[Compatibility Issue] Model does not change when skin is changed with Essential #659

Open dombomb64 opened 3 months ago

dombomb64 commented 3 months ago

When I switch my Essential outfit to one with a different skin, the CPM model does not change. Normally, when switching skins with Essential, the skin is able to change on the fly, but when CPM models are involved, it either stays as a custom model (if the game was booted with a CPM skin) or just uses the vanilla skin (if the game was booted with a skin without a CPM link). Restarting the game updates the model properly, but it would be better if Essential could communicate with CPM to change models like Essential can change skins. I don't know if I should have asked the devs of Essential instead, but they did make the client open-source, so I hope it's possible to add a mixin to communicate to CPM that the player's skin just updated.

THEkindKnight commented 2 months ago

maybe an implementation of a if else where if it finds essential on the client, it enables a subroutine to check the base skin again when resuming? (im not fully sure, its just an idea)