search

tom5454 / CustomPlayerModels

Customize your minecraft avatar!
https://www.curseforge.com/minecraft/mc-mods/custom-player-models
MIT License
149 stars 49 forks source link

Incompatibility with the next vivecraft upodate, because of internal changes #716

Open fayer3 opened 6 days ago

fayer3 commented 6 days ago

Hi, vivecraft dev here. then next vivecraft version will have some internal changes, which breaks this mixin https://github.com/tom5454/CustomPlayerModels/blob/master/CustomPlayerModels-1.20.4/src/platform-shared/java/com/tom/cpm/mixin/compat/VRArmRendererMixin_%24vivecraft.java#L50-L65

because I renamed that method from renderItem to renderHand

am I correct in the assumption that if we directly use the getTextureLocation method to get the skin this wouldn't be needed? if so I can change that to that.

tom5454 commented 6 days ago

Yes, that's correct.

fayer3 commented 4 days ago

okay, then I'll change the skin fetch to that. if you could make that redirect optional, so that the game doesn't break. that would be great

StarleetTW commented 1 day ago

tom, fix it please

fayer3 commented 19 hours ago

okay, then I'll change the skin fetch to that. if you could make that redirect optional, so that the game doesn't break. that would be great

I did that btw here https://github.com/fayer3/VivecraftMod/commit/1244e0c9061de6e86c4540bf9fa9285e1f372091 that will be in vivecraft 1.2.0