search

tomLadder / react-native-echarts-wrapper

📈Powerful React-Native ECharts Wrapper 📊
MIT License
177 stars 62 forks source link

toString is broken when enable Hermes #60

Open chj-damon opened 4 years ago

chj-damon commented 4 years ago

https://github.com/facebook/hermes/issues/288

any idea that maybe we can convert toString() to pure javascript string?

tomLadder commented 3 years ago

@chj-damon Thank you for pointing this out. I think there is a way to fix this. I will provide further information in the future.

chj-damon commented 3 years ago

@tomLadder are you making some progress now?

surethink commented 3 years ago

@chj-damon Thank you for pointing this out. I think there is a way to fix this. I will provide further information in the future.

any update on this? thanks

this info may be helpful https://github.com/facebook/hermes/commit/0ee971d1dffd28882a15034d803afe5f2ab439d7

chj-damon commented 3 years ago

@surethink try this: https://github.com/thundersdata-frontend/td-design/tree/master/packages/react-native-echarts it works with or without hermes.

weishengkui commented 1 year ago

@tomLadder are you making some progress now? 最近也在追查 funtion.toString() 的问题， 佩服妹子锲而不舍的精神， 赞赞赞！哈哈。。。。