tomMoral / dicodile

Experiments for "Distributed Convolutional Dictionary Learning (DiCoDiLe): Pattern Discovery in Large Images and Signals"
https://tommoral.github.io/dicodile/
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

Gait example #22

Closed rprimet closed 3 years ago

rprimet commented 3 years ago

Not yet complete, but it could use a first round of reviews I guess :-)

The main omission is the step detector (I need some more guidance for that)

agramfort commented 3 years ago

how long does the example take to run?

rprimet commented 3 years ago

Around 30 seconds on my laptop, not counting data download

codecov[bot] commented 3 years ago

Codecov Report

Merging #22 (903d268) into main (7f429c8) will increase coverage by 0.36%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   74.15%   74.52%   +0.36%     
==========================================
  Files          41       43       +2     
  Lines        2573     2610      +37     
==========================================
+ Hits         1908     1945      +37     
  Misses        665      665              
Flag Coverage Δ
unittests 74.52% <100.00%> (+0.36%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dicodile/data/gait.py 100.00% <100.00%> (ø)
dicodile/data/tests/test_gait.py 100.00% <100.00%> (ø)
dicodile/data/text.py
dicodile/data/tests/test_mandrill.py
dicodile/data/tests/test_images.py 100.00% <0.00%> (ø)
dicodile/data/_text.py 0.00% <0.00%> (ø)
dicodile/_dicodile.py 79.51% <0.00%> (+0.24%) :arrow_up:
dicodile/data/images.py 76.92% <0.00%> (+12.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f429c8...903d268. Read the comment docs.