search

tomMoral / dicodile

Experiments for "Distributed Convolutional Dictionary Learning (DiCoDiLe): Pattern Discovery in Large Images and Signals"
https://tommoral.github.io/dicodile/
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

Remove thread locals #36

Closed rprimet closed 3 years ago

rprimet commented 3 years ago

This PR removes thread locals but keeps a global worker pool. At some point down the line it might be useful to pass an optional worker pool to dicodile? (for instance, shut down worker if the pool was created in dicodile, and do not shut down if it was passed from outside?)

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (44a1219) into main (bc6b7f4) will decrease coverage by 0.06%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   74.53%   74.46%   -0.07%     
==========================================
  Files          43       43              
  Lines        2611     2604       -7     
==========================================
- Hits         1946     1939       -7     
  Misses        665      665
Flag Coverage Δ
unittests 74.46% <93.75%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dicodile/workers/reusable_workers.py 86.41% <93.75%> (-1.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc6b7f4...44a1219. Read the comment docs.