tomMoral / dicodile

Experiments for "Distributed Convolutional Dictionary Learning (DiCoDiLe): Pattern Discovery in Large Images and Signals"

https://tommoral.github.io/dicodile/

BSD 3-Clause "New" or "Revised" License

18 stars 10 forks source link

Gather coverage data for unit tests and upload to codecov #4

Closed rprimet closed 3 years ago

tomMoral commented 3 years ago

It seems that we still don't see CI run in PR. I guess we have a config issue but I don't know why.

Could you check this?

Also, it looks like there is an issue in the config as we cannot see the coverage report in files: https://codecov.io/gh/rprimet/dicodile/src/97d67379b8a6f65bf1d3de6adfcc1ac3344261f3/dicodile/update_z/coordinate_descent.py

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d20c65b). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   73.34%           
=========================================
  Files             ?       36           
  Lines             ?     2529           
  Branches          ?        0           
=========================================
  Hits              ?     1855           
  Misses            ?      674           
  Partials          ?        0

Flag	Coverage Δ
unittests	`73.34% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d20c65b...1948f8b. Read the comment docs.

rprimet commented 3 years ago

It seems that we still don't see CI run in PR. I guess we have a config issue but I don't know why.

Could you check this?

Yes, there's a config issue related to the action triggers I guess. We could revert it to [push, pull_requests] ?

Also, it looks like there is an issue in the config as we cannot see the coverage report in files: https://codecov.io/gh/rprimet/dicodile/src/97d67379b8a6f65bf1d3de6adfcc1ac3344261f3/dicodile/update_z/coordinate_descent.py

I'm having no issue seeing the coverage report at this link, could you confirm that it doesn't work for you?

tomMoral commented 3 years ago

Yes, there's a config issue related to the action triggers I guess. We could revert it to [push, pull_requests] ?

Perfect Thanks! It was indeed the setup as the default branch in this repo is master and not main but I guess using all pushes is fine.

I'm having no issue seeing the coverage report at this link, could you confirm that it doesn't work for you?

It does work now, I don't know why it failed when I checked but it is fine now. I will merge this one! Thanks