Closed rprimet closed 2 years ago
Merging #48 (bb23361) into main (ad30e87) will increase coverage by
1.29%
. The diff coverage is97.46%
.
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 74.50% 75.80% +1.29%
==========================================
Files 43 43
Lines 2593 2748 +155
==========================================
+ Hits 1932 2083 +151
- Misses 661 665 +4
Flag | Coverage Δ | |
---|---|---|
unittests | 75.80% <97.46%> (+1.29%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
dicodile/update_z/distributed_sparse_encoder.py | 74.25% <71.42%> (-2.34%) |
:arrow_down: |
dicodile/update_z/coordinate_descent.py | 41.17% <80.00%> (-0.63%) |
:arrow_down: |
dicodile/update_z/dicod.py | 78.68% <100.00%> (+0.84%) |
:arrow_up: |
.../update_z/tests/test_distributed_sparse_encoder.py | 100.00% <100.00%> (ø) |
|
dicodile/utils/csc.py | 100.00% <100.00%> (ø) |
|
dicodile/utils/dictionary.py | 51.45% <100.00%> (+19.02%) |
:arrow_up: |
dicodile/utils/tests/test_csc.py | 100.00% <100.00%> (ø) |
|
dicodile/workers/dicod_worker.py | 94.14% <100.00%> (+0.06%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ad30e87...bb23361. Read the comment docs.
The example is nice and working! LGTM! thanks @rprimet
🙏 @rprimet !
Very rough draft of part 1 of the implementation of #46 for discussion / comments.