tomMoral / dicodile

Experiments for "Distributed Convolutional Dictionary Learning (DiCoDiLe): Pattern Discovery in Large Images and Signals"
https://tommoral.github.io/dicodile/
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

Get max error patch #51

Closed rprimet closed 2 years ago

rprimet commented 2 years ago

Draft PR, not ready yet, needs more tests including one that exercises the full greedy learning example.

Fixes #49

codecov[bot] commented 2 years ago

Codecov Report

Merging #51 (f79a21f) into main (2588788) will increase coverage by 1.62%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   75.80%   77.42%   +1.62%     
==========================================
  Files          43       43              
  Lines        2748     2809      +61     
==========================================
+ Hits         2083     2175      +92     
+ Misses        665      634      -31     
Flag Coverage Δ
unittests 77.42% <100.00%> (+1.62%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dicodile/utils/segmentation.py 96.51% <ø> (ø)
dicodile/_dicodile.py 85.71% <100.00%> (+5.95%) :arrow_up:
dicodile/tests/test_dicodile.py 100.00% <100.00%> (ø)
dicodile/update_z/dicod.py 79.03% <100.00%> (+0.34%) :arrow_up:
dicodile/update_z/distributed_sparse_encoder.py 75.70% <100.00%> (+1.44%) :arrow_up:
.../update_z/tests/test_distributed_sparse_encoder.py 100.00% <100.00%> (ø)
dicodile/utils/constants.py 100.00% <100.00%> (ø)
dicodile/utils/dictionary.py 73.33% <100.00%> (+21.87%) :arrow_up:
dicodile/workers/dicod_worker.py 94.26% <100.00%> (+0.12%) :arrow_up:
dicodile/workers/dicodile_worker.py 92.85% <100.00%> (+0.54%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2588788...f79a21f. Read the comment docs.