search

tomMoral / dicodile

Experiments for "Distributed Convolutional Dictionary Learning (DiCoDiLe): Pattern Discovery in Large Images and Signals"
https://tommoral.github.io/dicodile/
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

Fix max iter #54

Closed hndgzkn closed 2 years ago

hndgzkn commented 2 years ago

Fixes number of local segments and local max_iter in compliance with alphacsc implementation

codecov[bot] commented 2 years ago

Codecov Report

Base: 77.42% // Head: 77.50% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (340de5c) compared to base (1e4bc06). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== + Coverage 77.42% 77.50% +0.07% ========================================== Files 43 42 -1 Lines 2809 2818 +9 ========================================== + Hits 2175 2184 +9 Misses 634 634 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `77.50% <100.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/tomMoral/dicodile/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau) | Coverage Δ | | |---|---|---| | [dicodile/tests/test\_config.py](https://codecov.io/gh/tomMoral/dicodile/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvdGVzdHMvdGVzdF9jb25maWcucHk=) | `100.00% <100.00%> (ø)` | | | [dicodile/utils/segmentation.py](https://codecov.io/gh/tomMoral/dicodile/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvdXRpbHMvc2VnbWVudGF0aW9uLnB5) | `96.51% <100.00%> (ø)` | | | [dicodile/utils/tests/test\_segmentation.py](https://codecov.io/gh/tomMoral/dicodile/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvdXRpbHMvdGVzdHMvdGVzdF9zZWdtZW50YXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [dicodile/workers/dicod\_worker.py](https://codecov.io/gh/tomMoral/dicodile/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvd29ya2Vycy9kaWNvZF93b3JrZXIucHk=) | `94.27% <100.00%> (+0.01%)` | :arrow_up: | | [dicodile/\_\_init\_\_.py](https://codecov.io/gh/tomMoral/dicodile/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvX19pbml0X18ucHk=) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tomMoral commented 2 years ago

Oups sorry, I went too fast ^^ This is why it is nice to have some tests :)

hndgzkn commented 2 years ago

Oups sorry, I went too fast ^^ This is why it is nice to have some tests :)

Tests added and pass. Ok to merge!