tomMoral / dicodile

Experiments for "Distributed Convolutional Dictionary Learning (DiCoDiLe): Pattern Discovery in Large Images and Signals"
https://tommoral.github.io/dicodile/
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

ENH remove backend checks for mpi #56

Closed hndgzkn closed 1 year ago

hndgzkn commented 2 years ago

Simplifies code removing all backend == "mpi"checks.

MPI backend is not clearly separated. If another backend is to be implemented in the future, it would be better to implement in separate classes to a common Interface instead of if checks.

codecov[bot] commented 2 years ago

Codecov Report

Base: 78.22% // Head: 78.29% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (b7e28b9) compared to base (c6873e7). Patch coverage: 86.48% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #56 +/- ## ========================================== + Coverage 78.22% 78.29% +0.06% ========================================== Files 42 43 +1 Lines 2889 2856 -33 ========================================== - Hits 2260 2236 -24 + Misses 629 620 -9 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.29% <86.48%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/tomMoral/dicodile/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau) | Coverage Δ | | |---|---|---| | [dicodile/workers/dicod\_worker.py](https://codecov.io/gh/tomMoral/dicodile/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvd29ya2Vycy9kaWNvZF93b3JrZXIucHk=) | `95.99% <85.71%> (+1.41%)` | :arrow_up: | | [dicodile/workers/dicodile\_worker.py](https://codecov.io/gh/tomMoral/dicodile/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvd29ya2Vycy9kaWNvZGlsZV93b3JrZXIucHk=) | `92.85% <100.00%> (ø)` | | | [dicodile/workers/main\_worker.py](https://codecov.io/gh/tomMoral/dicodile/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvd29ya2Vycy9tYWluX3dvcmtlci5weQ==) | `94.73% <100.00%> (ø)` | | | [dicodile/\_dicodile.py](https://codecov.io/gh/tomMoral/dicodile/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvX2RpY29kaWxlLnB5) | `85.71% <0.00%> (ø)` | | | [dicodile/\_\_init\_\_.py](https://codecov.io/gh/tomMoral/dicodile/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.