tomMoral / dicodile

Experiments for "Distributed Convolutional Dictionary Learning (DiCoDiLe): Pattern Discovery in Large Images and Signals"
https://tommoral.github.io/dicodile/
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

ENH add gait participants tsv #60

Closed CedricAllain closed 1 year ago

tomMoral commented 1 year ago

The data files should not be commited in dicodile but retrieved from the archive if possible. Can you see if you can't simply unzip it in the dicodile/data/gait.py file instead of putting them in the git history?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 34.69% and project coverage change: -0.79 :warning:

Comparison is base (8e5a75a) 78.29% compared to head (8a066fe) 77.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== - Coverage 78.29% 77.50% -0.79% ========================================== Files 43 43 Lines 2856 2899 +43 ========================================== + Hits 2236 2247 +11 - Misses 620 652 +32 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `77.50% <34.69%> (-0.79%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/tomMoral/dicodile/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau) | Coverage Δ | | |---|---|---| | [dicodile/data/gait.py](https://app.codecov.io/gh/tomMoral/dicodile/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Moreau#diff-ZGljb2RpbGUvZGF0YS9nYWl0LnB5) | `46.66% <34.69%> (-53.34%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

CedricAllain commented 1 year ago

The data files should not be commited in dicodile but retrieved from the archive if possible. Can you see if you can't simply unzip it in the dicodile/data/gait.py file instead of putting them in the git history?

Updated, used a regex to recreate the JSON file.