[Bug] Hang with huge route table on ROS 7.1.3

[bdn76]

Describe the issue

Plugin hang on update route table with huge of entries (10000+). Work fine after:

        if self.api.connected():
            await self.hass.async_add_executor_job(self.get_system_health)

        #if self.api.connected():
        #    await self.hass.async_add_executor_job(self.get_route)

        if self.api.connected():
            await self.hass.async_add_executor_job(self.get_interface)

Consider move route table upload to config options.

How to reproduce the issue

Connect plugin to ROS 7.1.3+ with huge routing table (BGP for example).

Expected behavior

Do not sync routing table or make optional switch for route table load.

Screenshots

I'm found large CPU consumption on tik device:

After comment route table loading CPU utilization went down to normal.

Software versions

All fields in this sections are required.

• Home Assistant version: 2022.3.3
• Mikrotik Router integration version: 2.0
• Mikrotik Hardware: RBD52G-5HacD2HnD
• RouterOS version: 7.1.3

[tomaae]

10000+ entries? I dont have an environment where I have something like that to test. Did it really hang, or just took long?

[bdn76]

Yes.

Took long about 5-6 minutes.

[tomaae]

I'm not authorized to use BGP, so not sure how to test and workaround this issue at the moment.

[bdn76]

What about option for route load like this:

?

[tomaae]

Not in this case, because of a way it is used. I may be able to find a way, since I only need to find an interface for default route. There may be more efficient way to do that.

[tomaae]

what will you get when you type this in cli? /ip route print terse where dst-address=0.0.0.0/0

[bdn76]

[admin@router] > /ip route print terse where dst-address=0.0.0.0/0
   DAv   dst-address=0.0.0.0/0 routing-table=main pref-src="" gateway=pppoe-out1 immediate-gw=pppoe-out1 distance=10 scope=30 target-scope=10 suppress-hw-offload=no 
   D d   dst-address=0.0.0.0/0 routing-table=main pref-src="" gateway=192.168.8.1 immediate-gw=192.168.8.1%lte1 distance=20 scope=30 target-scope=10 vrf-interface=lte1 suppress-hw-offload=no 

[admin@router] > 

[tomaae]

Assuming lte1 is your default internet gateway, this works. Was there any noticable load on router side with your setup?

This should show only default gateway interface. /ip route print terse where dst-address=0.0.0.0/0 and vrf-interface

[bdn76]

Assuming lte1 is your default internet gateway, this works. Was there any noticable load on router side with your setup?

No, default gw is pppoe (letter "A" in "DAv") - lte1 is backup (no letter "A" in "D d". CPU utilization without route table loading is around 1-2%.

This should show only default gateway interface. /ip route print terse where dst-address=0.0.0.0/0 and vrf-interface

[admin@router] > /ip route print terse where dst-address=0.0.0.0/0 and vrf-interface
   D d   dst-address=0.0.0.0/0 routing-table=main pref-src="" gateway=192.168.8.1 immediate-gw=192.168.8.1%lte1 distance=20 scope=30 target-scope=10 vrf-interface=lte1 suppress-hw-offload=no

Incorrect.

[tomaae]

Hmm, this is tricky, since pppoe does not show interface. I will have to research this further, since this is obviously correct way to approach gateway detection without causing high CPU load in cases such as yours. I also have close to none experience with pppoe, which is a problem as well.

[tomaae]

hmm, but does it detect any devices behind pppoe interface? if not, this will be no-issue.

[bdn76]

This one:

[admin@router] > /interface print where name=pppoe-out1
Flags: R - RUNNING
Columns: NAME, TYPE, ACTUAL-MTU
 #   NAME        TYPE       ACTUAL-MTU
13 R pppoe-out1  pppoe-out        1492
[admin@router] > 

[tomaae]

what I mean is route output. but I just found this in different documentation

immediate-gw (string) | Shows actual (resolved) gateway and interface that will be used for packet forwarding. Displayed in format [ip%interface]. -- | --

while not strictly true, since ip% is not present in your case, it could be useful. I just wish I had more complex setups to get this output from so I can be sure.

[tomaae]

it may actually not be possible. API library still accesses whole table even when limiting selection. Not sure what to do here, I cant find any other way to find default gateway.