tomaae / homeassistant-mikrotik_router

Mikrotik router integration for Home Assistant
Apache License 2.0
292 stars 48 forks source link

Support for additional attributes on execute #285

Closed ivanpavlina closed 1 year ago

ivanpavlina commented 1 year ago

Proposed change

Linking the issue #284 . Problem with RouterOS check-for-updates method which hangs on unexpected response.

Execute method is extended with attributes=None params. In check-for-updates call there is a hardcoded 10 second duration value, we can set it to some other dynamic value if you wish, but from my testing if this call didn't finish in 10 seconds, it wont finish ever.

Type of change

Checklist

tomaae commented 1 year ago

thanks