tomaae / homeassistant-mikrotik_router

Mikrotik router integration for Home Assistant
Apache License 2.0
292 stars 48 forks source link

[Bug] Duplicate names in device #306

Closed mvdwetering closed 11 months ago

mvdwetering commented 11 months ago

Describe the issue

I noticed that devices in exposed by the integration have duplicate names in the device. I think it is new as I did not notice it before.

I noticed first in the update dialog image

In this case "hAP ac³" is the name I gave it when adding the integration. The integration itself seems to add the device model.

How to reproduce the issue

Add router to integration, go to the device exposing the update entity.

Expected behavior

A clear name for devices.

I see why the integration name + something method is used as a lot of stuff is exposed as devices to have it all managable.

Maybe just not duplicate the name for the main router/unit device? or call it with a different postfix than model name, but can't come up with something good. Thought about "hAP ac3 main", "hAP ac3 unit", but don't like any of them.

FYI there is a discussion in the architecture repo about subdevices which may (or may not) help in the future https://github.com/home-assistant/architecture/discussions/957

Screenshots

Software versions

Diagnostics data

Traceback/Error logs

Additional context

Edit: Actually after writing all this, maybe it is more noticable for me because I name the routers by the model. Not sure how I would name them otherwise...

Hmmm... I also see duplication on the devices added for the client traffic. image

The RX/TX sensors have the device name included. This means that in some contexts HA shows "MICHEL-PC2 MICHEL-PC2 TX" image

tomaae commented 11 months ago

I dont see what is a problem here. Everything is based on the integration instance you named. part of it is router itself (as system device in the list) which is represented by its model name. Standard naming is: Instance, Device, Entity

In case of device tracker, that one is weird, I have to look into it. Edit: Looks like there is a bug where this happens with custom names, but not mac.

mvdwetering commented 11 months ago

Ah, ok. I got confused to t the double "hAP ac" in the name, but I see where it is coming from. Thanks for fixing the other entity names with 2.14 👍