tomaae / homeassistant-mikrotik_router

Mikrotik router integration for Home Assistant
Apache License 2.0
302 stars 51 forks source link

[Bug] unable to install version from master via HACS #346

Closed L2jLiga closed 7 months ago

L2jLiga commented 7 months ago

Describe the issue

Unable to install version from master branch via HACS

How to reproduce the issue

  1. Open HA
  2. Navigate to HACS
  3. Click "Explore and download repositories"
  4. Search for any with for "Mikrotik Router" integration and click on it
  5. Click "Download"
  6. In "Select version" dropdown choose "master"
  7. Click "Download"

Expected behavior

Integration installed successfully

Software versions

Diagnostics data

This is happens because hacs.json contains "zip_release": true, so HACS trying to download "master" release and expectly fails with 404 error.

I've created issue in HACS firstly, however HACS maintainer answered that it's expected behavior.

https://github.com/hacs/integration/issues/3513

tomaae commented 7 months ago

well, since HACS decided it will no longer be possible to install master this way, it wont be possible. Nothing I can do there. Obviously, zip release cannot be generated for master, so I will be disabling master from HACS. Too bad they removed this feature.