search

tomaae / homeassistant-mikrotik_router

Mikrotik router integration for Home Assistant
Apache License 2.0
301 stars 50 forks source link

Integration version is missing (or wrong) #367

Closed Cougar closed 1 month ago

Cougar commented 1 month ago

Somehow the version number has been missed a long time. This is the version that will be shown to the user

https://github.com/tomaae/homeassistant-mikrotik_router/blob/de1ca6a6f6cc37e37c9e6da216849bb5063e66f6/custom_components/mikrotik_router/manifest.json#L16

Screenshot 2024-07-14 at 16-59-33 Settings – Home Assistant

tomaae commented 1 month ago

Yes I know, I dont use internal version in any of my integrations. Its easy to forget about and then it causes real issues.

Cougar commented 1 month ago

It is usable for normal users where they can see if their integration is up to date or not. Right now there is no easy way to make sure that latest version is running. I don't know if this has any other advantage. It is definitely something that needs to be remembered and updated for every release at least.

tomaae commented 1 month ago

I will look into it, if it can be included by release automation. otherwise even master would have release version which will cause even more confusion during debugging

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 1 month ago

This issue was closed because it has been stalled for 5 days with no activity.