[Bug] Network traffic is showing as zero

tomaae / homeassistant-truenas

TrueNAS integration for Home Assistant

Apache License 2.0

183 stars 16 forks source link

[Bug] Network traffic is showing as zero #164

Closed Alister-Zeus closed 1 month ago

Alister-Zeus commented 1 month ago

Describe the issue

How to reproduce the issue

Expected behavior

Screenshots

Software versions

Home Assistant version:
Core 2024.7.2 Supervisor 2024.06.2 Operating System 12.4 Frontend 20240710.0
TrueNAS integration version: v1.3b2
TrueNAS version: TrueNAS-13.0-U6.2

Diagnostics data

Traceback/Error logs

Additional context

home-assistant_truenas_2024-07-15T18-42-28.184Z.log config_entry-truenas-555d1dedcce422142e41a8785774e4a6.json home-assistant_truenas_2024-07-15T18-18-00.193Z.log

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 1 month ago

This issue was closed because it has been stalled for 5 days with no activity.

herden-system commented 1 month ago

Problem still exists.

drzoidberg33 commented 2 weeks ago

Yep, I recently started using this integration and noticed the same on my Core system.

I dug into it a bit and this commit is what's causing the problem: https://github.com/tomaae/homeassistant-truenas/commit/a59ea1e901fbea72a8769e7d56effcf61585c412

I'm not entirely sure what the intent was with this because afaict this is completely redundant.

drzoidberg33 commented 2 weeks ago

@tomaae sorry to ping you, but just wanted to find out exactly what the intent was for the above commit - I can submit a PR to fix it the issue reported here once I have a bit more info.

tomaae commented 2 weeks ago

No problem with a ping. I'm currently too busy with work and life to dive into github stuff. I will certainly go trough everything, open or closed once I have everything in order, so dont worry about status or github automations.

drzoidberg33 commented 1 week ago

Looks like the units of measurement are off once fixing the zero response issue.

I changed mine to just grab the raw value from the graph api and set the native unit to UnitOfDataRate.BITS_PER_SECOND (here and here) which seems to be what the raw value is representing, although I couldn't find any documentation verifying this - but my graphs look correct now.

Note this is for TrueNAS core, not sure if there are API differences with Scale.