search

tomadams / web2020

0 stars 0 forks source link

Library Homepage - Search Box - Website #13

Closed tomadams closed 3 years ago

tomadams commented 4 years ago

Right now I would prefer that the search request does not contain the library tag. This way a person is able to see the full list of search results. If the list too long, they can always filter it with a tag.

srunkows commented 4 years ago

fixed, please review.

tomadams commented 4 years ago

Looks good.

tomadams commented 4 years ago

Mila would prefer to rename the tab in the library homepage search box from "Website", to "Library Website" (with a title from "Website search" to "Library Website Search"). She would like to have it only display both Library and Archives content. I know you were looking into check boxes instead of radio buttons on the search field. Please let us know what you are able to do.

srunkows commented 4 years ago

This is done and ready for review.

Because the search currently only uses radio buttons, I can only pass 1 hidden value to the search engine. For now, I set it to Library. When I implement the checkboxes, I should be able to pass multiple hidden values to the search engine and return results for both Library & Archives instead of just Library.

tomadams commented 4 years ago

Understood. Will check if Mila is fine with it.

tomadams commented 3 years ago

With the new search filter checkbox enhancements, looks like adding a "Library Website Search" that includes both library and the archives will soon be a reality.

srunkows commented 3 years ago

With the new search filter checkbox enhancements, looks like adding a "Library Website Search" that includes both library and the archives will soon be a reality.

It is now a reality. I just made the update to the search box on your landing page.

tomadams commented 3 years ago

Thanks. With the added bonus that memory board is the top listing. Outstanding.