search

tomahawk-player / tomahawk-resolvers

Resolver plugins for Tomahawk Player
216 stars 113 forks source link

Amazon resolver doesn't play/errors #123

Closed aschampion closed 8 years ago

aschampion commented 8 years ago

Tomahawk 0.8.99, Amazon resolver nightly .axe 0.0.7:

Tue Jul 5 2016 - 14:08:16 [5]: void AudioEngine::playItem(Tomahawk::playlistinterface_ptr, const result_ptr&, const query_ptr&) "amazonprimemusic://amzn://track/210/COID/3201e4bc-6f04-4e7b-9e05-20bc71587ac5" 
Tue Jul 5 2016 - 14:08:16 [5]: void AudioEngine::loadTrack(const result_ptr&) "amazonprimemusic://amzn://track/210/COID/3201e4bc-6f04-4e7b-9e05-20bc71587ac5" 
Tue Jul 5 2016 - 14:08:16 [1]: void AudioOutput::stop() 
Tue Jul 5 2016 - 14:08:16 [1]: void AudioOutput::setState(AudioOutput::AudioState) 
Tue Jul 5 2016 - 14:08:16 [8]: Enqueueing command to rw thread: "logplayback" 
Tue Jul 5 2016 - 14:08:16 [1]: virtual void PlayableProxyModel::setCurrentIndex(const QModelIndex&) 
Tue Jul 5 2016 - 14:08:16 [9]: Committing "logplayback" "14aa9de5-c549-470e-9583-1ce87986d785" 
Tue Jul 5 2016 - 14:08:16 [5]: void AudioEngine::performLoadIODevice(const result_ptr&, const QString&) "amazonprimemusic://amzn://track/210/COID/3201e4bc-6f04-4e7b-9e05-20bc71587ac5" 
Tue Jul 5 2016 - 14:08:16 [0]: JAVASCRIPT: "/home/championa/.local/share/Tomahawk/manualresolvers/amazon/content/contents/code/amazon.js:1" "SyntaxError: Unexpected string "_adapter_getStreamUrl( {qid: '25f58ac7-31fb-4cc5-a723-091b42e270fa', url: 'amazonprimemusic://amzn://track/210/COID/3201e4bc-6f04-4e7b-9e05-20bc71587ac5'} );} else {    Tomahawk.resolver.instance."" "undefined" 
Tue Jul 5 2016 - 14:08:16 [8]: void Tomahawk::Source::onPlaybackFinished(const track_ptr&, const Tomahawk::PlaybackLog&) "Track(AfroCubism - Karamo)" 
Tue Jul 5 2016 - 14:08:16 [8]: Enqueueing command to thread: Tomahawk::DatabaseWorker(0x7f9b00002200) 0 "loadsocialactions" 
Tue Jul 5 2016 - 14:08:16 [9]: virtual void Tomahawk::DatabaseCommand_LoadSocialActions::exec(Tomahawk::DatabaseImpl*) 
Tue Jul 5 2016 - 14:08:16 [1]: void Tomahawk::Pipeline::checkQIDState(const query_ptr&)   "534c0939-c2b3-444f-8212-371832ab9546"   1 
Tue Jul 5 2016 - 14:08:16 [8]: Dispatching to resolver "DatabaseResolver" 0 "Query(534c0939-c2b3-444f-8212-371832ab9546, AfroCubism - Karamo)" false "534c0939-c2b3-444f-8212-371832ab9546" 
Tue Jul 5 2016 - 14:08:16 [8]: Enqueueing command to thread: Tomahawk::DatabaseWorker(0x7f9b00002200) 0 "dbresolve" 
Tue Jul 5 2016 - 14:08:16 [9]: No candidates found in first pass, aborting resolve "Track(AfroCubism - Karamo)" 
Tue Jul 5 2016 - 14:08:17 [8]: void DatabaseResolver::gotResults(Tomahawk::QID, QList<QSharedPointer<Tomahawk::Result> >) "534c0939-c2b3-444f-8212-371832ab9546" 0 
Tue Jul 5 2016 - 14:08:17 [1]: void Tomahawk::Pipeline::checkQIDState(const query_ptr&)   "534c0939-c2b3-444f-8212-371832ab9546"   1 
Tue Jul 5 2016 - 14:08:17 [8]: Dispatching to resolver "Amazon Prime Music" 8000 "Query(534c0939-c2b3-444f-8212-371832ab9546, AfroCubism - Karamo)" false "534c0939-c2b3-444f-8212-371832ab9546" 
Tue Jul 5 2016 - 14:08:17 [0]: JAVASCRIPT: "/home/championa/.local/share/Tomahawk/manualresolvers/amazon/content/contents/code/amazon.js" : "Executing 1 deferred SQL statements in transaction" 
Tue Jul 5 2016 - 14:08:17 [1]: void Tomahawk::Pipeline::checkQIDState(const query_ptr&)   "534c0939-c2b3-444f-8212-371832ab9546"   1 
Tue Jul 5 2016 - 14:08:17 [1]: void Tomahawk::Pipeline::checkQIDState(const query_ptr&)   "534c0939-c2b3-444f-8212-371832ab9546"   0 
Tue Jul 5 2016 - 14:08:17 [8]: Finished resolving: "Query(534c0939-c2b3-444f-8212-371832ab9546, AfroCubism - Karamo)"

Does this for all tracks. I'd love to have this working so may look into it later, but wanted to submit it here in case the problem & solution to the reported syntax error are obvious to existing devs.

theli-ua commented 8 years ago

Where is your tomahawk build from? What system is that on?

Do you get the same error if you build master yourself?

theli-ua commented 8 years ago

Also, does this happen to resolved tracks and/or collection tracks?

theli-ua commented 8 years ago

Actually, this is definitely not the latest build of tomahawk. It works on master

theli-ua commented 8 years ago

I suspect your version is coming from ubuntu nightlies, here, I created an issue about ubuntu nightlies being outdated https://github.com/tomahawk-player/tomahawk/issues/537