Cmake build incorrectly compares versions

tomahawk-player / tomahawk

Tomahawk, the multi-source music player

http://tomahawk-player.org

GNU General Public License v3.0

2.95k stars 367 forks source link

Cmake build incorrectly compares versions #655

Closed jasoncarr0 closed 5 years ago

jasoncarr0 commented 5 years ago

In the CMake module for TagLib, a string compare is used on the version instead of the appropriate version comparison. This can be likely fixed by replacing STRLESS with VERSION_LESS (see https://cmake.org/cmake/help/v3.0/command/if.html)

https://github.com/tomahawk-player/tomahawk/blob/master/CMakeModules/FindTaglib.cmake

dschmidt commented 5 years ago

Mind sending a PR?

jasoncarr0 commented 5 years ago

I'm working on it right now, just checking for all of the instances.

jasoncarr0 commented 5 years ago

Oh, turns out this specific instances was actually fixed, but another wasn't, it's just not fixed in the releases.