tomahawk-player / tomahawk

Tomahawk, the multi-source music player
http://tomahawk-player.org
GNU General Public License v3.0
2.95k stars 367 forks source link

Import FindTaglib.cmake from ECM 5.72.0 and mark Taglib as REQUIRED #677

Closed a17r closed 3 years ago

dschmidt commented 3 years ago

Great, thanks!

hugolm84 commented 3 years ago

This was a bit fast merge, why cannot we not use the ECM module directly?

a17r commented 3 years ago

This was a bit fast merge, why cannot we not use the ECM module directly?

That would mean depending on a release from 2020-07-11. No problem for me, but most projects shy away from introducing such hurdles for users of lesser distributions.