search

tomaka / hlua

Rust library to interface with Lua
MIT License
507 stars 48 forks source link

Follow up to #222: fix signatures of luaopen_* functions in hlua #223

Open fenollp opened 2 months ago

tomaka commented 2 months ago

Ah, I forgot to update the main library, which was definitely wrong. These functions are not documented at all, but looking at their source code they push a table on the stack, so we don't want to just expose them. Instead, they should at least return a PushGuard.

fenollp commented 2 months ago

Oh well, I'm just here to silence some compilation issues. To me it'd be fine if these fns continued to not return anything.

Looking at the code, I'm not confident at all in how I should create these PushGuards :) Maybe you can help?