search

tomaka / hlua

Rust library to interface with Lua
MIT License
510 stars 48 forks source link

Made Lua.get return None if the value is nil, even if the type being … #68

Closed Ameliorate closed 8 years ago

Ameliorate commented 8 years ago

…casted to has a value for nil

This change is slightly more breaking, since it changes behaviour instead of adding.

This is the second concern in #66.

tomaka commented 8 years ago

Thanks!

Could you also change into_get, and get/into_get in lua_tables.rs?

Ameliorate commented 8 years ago

The read_nil test was broken by this change, but I'm not entirely sure how to remove it, since it is in a different branch.

Ameliorate commented 8 years ago

Okay that either worked or broke everything.

tomaka commented 8 years ago

Thanks

Ameliorate commented 8 years ago

Could you publish a new version on crates.io? I have a crate that depends on this feature and I can't figure out how to use this package directly from git.