search

tomaka / rouille

Web framework in Rust
Apache License 2.0
1.09k stars 105 forks source link

add support for Serde #154

Closed cardoe closed 6 years ago

cardoe commented 6 years ago

Serde is the replacement for rustc-serialize so add support for it under a feature flag so that users can continue to use rustc-serialize until they have migrated their code. fixes #149.

cardoe commented 6 years ago

So I believe this won't break semver/ABI/API in the default case. But could definitely use some eyes and confirmations.

tomaka commented 6 years ago

Well, if a user has rouille = { version = "1", default-features = true } then this PR would remove support for rustc-serialize when they update.

tomaka commented 6 years ago

I think we should just remove rustc-serialize altogether.

cardoe commented 6 years ago

Did you mean default-features = false? Cause I agree that would break a user. I'm not sure how else to handle it. If I remove rustc-serialize then you'd have to go to a 2.0 since its a backwards incompatible change. You could make branch before that commit for 1.x if people are really interested in 1.x updates.

Let me know if you for sure want me to drop rustc-serialize and I'll update the PR.

purew commented 6 years ago

Any update on when this could be merged?

tomaka commented 6 years ago

Let's just drop rustc-serialize altogether, make serde non-optional, and then bump to 2.0.

cardoe commented 6 years ago

Should be complete with the latest commit.

cardoe commented 6 years ago

Rebased to ensure it applies cleanly and still passes all tests.

cardoe commented 6 years ago

Rebased and did the two things you requested.