search

tomaka / rouille

Web framework in Rust
Apache License 2.0
1.09k stars 105 forks source link

Update `multipart` to 0.13.6 #164

Closed kevinmehall closed 6 years ago

kevinmehall commented 6 years ago

multipart 0.5.1 had a bug resulting in data corruption (appended newlines) in binary file uploads, which has been resolved in more recent versions.

Unfortunately, this is a breaking change to the re-exported multipart API and there are more breaking changes to come.

tomaka commented 6 years ago

Thanks for the PR! Could you please add an entry to CHANGELOG.md indicating this change about multipart?

kevinmehall commented 6 years ago

@tomaka I rebased on master and added an entry to CHANGELOG.

cardoe commented 6 years ago

Would it make sense as a follow on to wrap up the return value so that multipart changes don't leak out into the ABI?

tomaka commented 6 years ago

Would it make sense as a follow on to wrap up the return value so that multipart changes don't leak out into the ABI?

IMO there is no additional value in doing that. If multipart changes their API I trust them that it is for a good reason, and thus that we would have to change our API as well for that same reason.