search

tomaka / rouille

Web framework in Rust
Apache License 2.0
1.12k stars 106 forks source link

Problem: routing url-encoded URLs doesn't work properly #173

Closed yrashk closed 6 years ago

yrashk commented 6 years ago

The URL is being decoded before any matching is done.

So, for example, /hello/%3Fa will not match /hello/a because %3F is already decoded to ?.

Solution: use raw URL to do the routing and decode individual parts instead.

tomaka commented 6 years ago

Thanks, looks good! Please also add am entry in the changelog and I'll merge.

yrashk commented 6 years ago

Updated the changelog.

yrashk commented 6 years ago

@tomaka Hi Pierre, what's the ETA for the next release? I am running into vendoring/frozen builds issues packaging my app for NixOS -- I am yet to see a workaround for git-based dependencies in their process. In the meantime, the only solid way for things to work is to depend on crates.io-only packages. Hence the question about the next release!

Thanks.

tomaka commented 6 years ago

@yrashk If you submit a PR that bumps the version in Cargo.toml and CHANGELOG, it will automatically be published once merged.

yrashk commented 6 years ago

Awesome, will do!

On Mon, Mar 5, 2018, 8:46 PM Pierre Krieger notifications@github.com wrote:

@yrashk https://github.com/yrashk If you submit a PR that bumps the version in Cargo.toml and CHANGELOG, it will automatically be published once merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tomaka/rouille/pull/173#issuecomment-370423520, or mute the thread https://github.com/notifications/unsubscribe-auth/AAABxOhEefQVn4GGArqldAo14JOMdVBFks5tbUG4gaJpZM4SOwzd .