tomaka / rouille

Web framework in Rust
Apache License 2.0
1.09k stars 105 forks source link

Rust 2018 macro compatibility #222

Closed dkaste closed 3 years ago

dkaste commented 4 years ago

In Rust 2018 it is generally preferred to write use statements to import macros. Due to the implementation details of the macros in rouille (using crate-local macros within macros), it is currently impossible to import them that way.

There are two ways to fix this:

I'm unsure which option would be more suitable for rouille, but I am willing to implement either of these changes.

Edit: Just realized that the minimum Rust version for this project is already above 1.30.

bradfier commented 3 years ago

Resolved by merging #223