search

tomaka / rouille

Web framework in Rust
Apache License 2.0
1.09k stars 105 forks source link

Replaces deprecated `try!` macro for `?` operator. #229

Closed gpestana closed 3 years ago

bestouff commented 4 years ago

In the meantime, does anyone have a workaround to eliminate the warning without vendoring rouille ? No amount of #[allow(deprecated)] around the post_input! macro does help.

oherrala commented 4 years ago

This is probably duplicate of #225. Both change 32 lines, but I didn't compare every line.

nikodemus commented 4 years ago

#![allow(deprecated)] on the toplevel of the file, before the use of rouille works.

Note the bang: #!

...but that's a big hammer and silences all deprecation notes for the file, not just the rouille one.

bestouff commented 4 years ago

Well, #![allow(deprecated)] at the very first line doesn't silence the warning in my code.

Got it: at the very first line in my main.rs it does indeed silence the warning, for all the files in the project. But it's way too big a hammer for me.

nikodemus commented 4 years ago

Huh, works for me. I'm still on rustc 1.40.0, though.

bestouff commented 4 years ago

(See previous comment, edited)

kalj commented 3 years ago

This is probably duplicate of #225. Both change 32 lines, but I didn't compare every line.

Yeah, exact duplicate of #225.

bradfier commented 3 years ago

The earlier PR #225 was cherry picked as 1096f2bceb641ea82c186760b8727ed61a93872b, thanks for the submission anyway!

gpestana commented 3 years ago

Thanks @bradfier !