search

tomaka / rouille

Web framework in Rust
Apache License 2.0
1.09k stars 105 forks source link

Fix some TODOs in Request and Content Encoding #234

Closed svenvdvoort closed 2 years ago

svenvdvoort commented 3 years ago

Hello there!

With some time on my hands currently, I decided to fix some TODOs throughout the code base of Rouille.

Let me know what you think. :)

Cheers, Sven.

bradfier commented 2 years ago

@svenvdvoort thanks for looking at these TODOs, I'm sorry it's taken so long for someone to look at your PR.

Could you rebase onto master and I'll review it once that's done?

svenvdvoort commented 2 years ago

Not a problem @bradfier , Thanks for considering my Pull Request. I've rebased my changed on the current master branch, so you can take a look.

bradfier commented 2 years ago

@svenvdvoort Sorry to be a pain but can you rebase once more?

I had to pin time to 0.3.2 to stop the 1.48 build from failing constantly.

svenvdvoort commented 2 years ago

@bradfier Yess, just rebased again to the latest master.

bradfier commented 2 years ago

Thanks!